Skip to content

fix: link SES mailbox add-on guidance#1441

Merged
superdav42 merged 2 commits into
mainfrom
fix/ses-email-accounts-link
Jun 16, 2026
Merged

fix: link SES mailbox add-on guidance#1441
superdav42 merged 2 commits into
mainfrom
fix/ses-email-accounts-link

Conversation

@superdav42

@superdav42 superdav42 commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Update the Amazon SES mailbox provisioning guidance to link to the Email Accounts add-on product page.
  • Allow integration wizard explainer lines to render safe HTML via wp_kses() so the new anchor is displayed instead of escaped.
  • Clean up PHPCS issues in the touched SES integration file so pre-commit passes.

Verification

  • php -l inc/integrations/providers/amazon-ses/class-amazon-ses-transactional-email.php
  • php -l views/wizards/host-integrations/activation.php
  • vendor/bin/phpcs inc/integrations/providers/amazon-ses/class-amazon-ses-transactional-email.php
  • vendor/bin/phpcs views/wizards/host-integrations/activation.php
  • vendor/bin/phpstan analyse inc/integrations/providers/amazon-ses/class-amazon-ses-transactional-email.php
  • git diff --check
  • Pre-commit hook passed: PHPCS + PHPStan

Summary by CodeRabbit

Release Notes

  • Updates
    • Updated transactional email settings help text with a direct link to the "Ultimate Multisite Emails" add-on for additional functionality information.
    • Improved content display in the host integration activation wizard to properly render formatted text.

@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

@superdav42, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 11 minutes and 36 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more credits in the billing tab to continue.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1612c568-936a-4641-bc19-b6d5f8cd5d36

📥 Commits

Reviewing files that changed from the base of the PR and between ff2784b and 5f7d07a.

📒 Files selected for processing (1)
  • inc/integrations/providers/amazon-ses/class-amazon-ses-transactional-email.php
📝 Walkthrough

Walkthrough

The mailbox_provision explainer text in the Amazon SES class now produces an HTML anchor linking to the "Ultimate Multisite Emails" add-on using sprintf/esc_url. The activation wizard view switches both $will and $will_not bullet rendering from esc_html to wp_kses with wu_kses_allowed_html. The intercept_wp_mail parameter is renamed from $return to $short_circuit, and PHPDoc is added or expanded across several public methods.

Changes

Amazon SES Explainer HTML and Activation Wizard Rendering

Layer / File(s) Summary
HTML explainer copy and wp_kses view rendering
inc/integrations/providers/amazon-ses/class-amazon-ses-transactional-email.php, views/wizards/host-integrations/activation.php
get_explainer_lines() builds the mailbox_provision message as an HTML link via sprintf/esc_url; the activation wizard switches both $will and $will_not bullet outputs from esc_html($line) to wp_kses($line, wu_kses_allowed_html()), with a minor trailing whitespace cleanup.
intercept_wp_mail rename and PHPDoc improvements
inc/integrations/providers/amazon-ses/class-amazon-ses-transactional-email.php
Renames the first parameter of intercept_wp_mail from $return to $short_circuit with updated PHPDoc; adds or expands PHPDoc on verify_domain, get_domain_verification_status, get_domain_dns_records, send_email, get_sending_statistics, set_sending_quota; applies whitespace alignment fix in parse_mail_headers.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • Ultimate-Multisite/ultimate-multisite#724: Directly touches the same intercept_wp_mail() method in class-amazon-ses-transactional-email.php, which this PR also modifies by renaming $return to $short_circuit.

Poem

🐇 A link where plain text used to be,
wp_kses lets the HTML run free.
$short_circuit hops into place,
PHPDoc blocks set a tidy pace.
The wizard now shows anchors bright —
Every bullet gleams with light! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: link SES mailbox add-on guidance' accurately describes the primary change in the PR, which adds a linked add-on description to the mailbox provisioning guidance in the Amazon SES integration.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/ses-email-accounts-link

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

Copy link
Copy Markdown

🔨 Build Complete - Ready for Testing!

📦 Download Build Artifact (Recommended)

Download the zip build, upload to WordPress and test:

🌐 Test in WordPress Playground (Very Experimental)

Click the link below to instantly test this PR in your browser - no installation needed!
Playground support for multisite is very limitied, hopefully it will get better in the future.

🚀 Launch in Playground

Login credentials: admin / password

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@inc/integrations/providers/amazon-ses/class-amazon-ses-transactional-email.php`:
- Line 59: Correct the typo in the user-facing translatable string within the
Amazon SES transactional email class. In the string containing "Install Email
Accounts Addo-on for that", change "Addo-on" to "Add-on" to fix the grammatical
error in the customer-visible text that will be translated.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2ec5fbbc-8fc7-4658-b735-e12ec3489c6e

📥 Commits

Reviewing files that changed from the base of the PR and between 2de42a4 and ff2784b.

📒 Files selected for processing (2)
  • inc/integrations/providers/amazon-ses/class-amazon-ses-transactional-email.php
  • views/wizards/host-integrations/activation.php

Comment thread inc/integrations/providers/amazon-ses/class-amazon-ses-transactional-email.php Outdated
@github-actions

Copy link
Copy Markdown

🔨 Build Complete - Ready for Testing!

📦 Download Build Artifact (Recommended)

Download the zip build, upload to WordPress and test:

🌐 Test in WordPress Playground (Very Experimental)

Click the link below to instantly test this PR in your browser - no installation needed!
Playground support for multisite is very limitied, hopefully it will get better in the future.

🚀 Launch in Playground

Login credentials: admin / password

@superdav42

Copy link
Copy Markdown
Collaborator Author

CLAIM_RELEASED reason=worker_complete runner=superdav42 ts=2026-06-16T22:50:03Z aidevops_version=3.20.85 opencode_version=1.17.7

@superdav42 superdav42 added the status:available Task is available for claiming label Jun 16, 2026
@superdav42 superdav42 merged commit 0a5d212 into main Jun 16, 2026
11 checks passed
@superdav42

Copy link
Copy Markdown
Collaborator Author

Summary

  • Update the Amazon SES mailbox provisioning guidance to link to the Email Accounts add-on product page.
  • Allow integration wizard explainer lines to render safe HTML via wp_kses() so the new anchor is displayed instead of escaped.
  • Clean up PHPCS issues in the touched SES integration file so pre-commit passes.

Verification

  • php -l inc/integrations/providers/amazon-ses/class-amazon-ses-transactional-email.php
  • php -l views/wizards/host-integrations/activation.php
  • vendor/bin/phpcs inc/integrations/providers/amazon-ses/class-amazon-ses-transactional-email.php
  • vendor/bin/phpcs views/wizards/host-integrations/activation.php
  • vendor/bin/phpstan analyse inc/integrations/providers/amazon-ses/class-amazon-ses-transactional-email.php
  • git diff --check
  • Pre-commit hook passed: PHPCS + PHPStan


Merged via PR #1441 to main.
Merged by deterministic merge pass (pulse-wrapper.sh).


aidevops.sh v3.20.85 spent 18m on this as a headless bash routine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review-feedback-scanned Merged PR already scanned for quality feedback status:available Task is available for claiming

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant